Good aftermarket xbox controller
 

The factory ones all seem to have the same problem for me and friends....when they get older the vibration makes batteries go loose and disconnect controller so you have to play agmes vibration off. Want a more rugged controller where this wont happen.

I have found that most aftermarket wireless controllers are cheap and worse than the ones that come with the console. My brothers Afterglow xbox 360 controller is pretty good except it is not wireless and it has dumb lights on it that annoying.

I use the Gamestop controllers and it's pretty good for me.

Have you thought about getting a play and charge kit and taping the battery back into place? It's probably cheaper than getting another controller, even a third party controller.

Would taping work?

If your problem is that the batteries are shaking themselves loose while vibrating, it's worth a try. If you have a play and charge kit, you might never have to remove the battery pack again. Besides, the less you have to detach the battery pack, the less wear and tear goes into the locking mechanism, and hence, a snugger fit.